Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser locks up on extremely long pages #258

Open
AufbeschissenerKunde opened this issue Jun 4, 2016 · 3 comments
Open

Browser locks up on extremely long pages #258

AufbeschissenerKunde opened this issue Jun 4, 2016 · 3 comments

Comments

@AufbeschissenerKunde
Copy link

Here's a fun test case for you: http://faculty.washington.edu/rturner1/AustraLearn_GBR.mht

This page is nearly 1500 pages long in print-preview. (I looked just to get that figure.) When I try to search this page, the browser totally locks up, is marked as "not responding," and turns pale. I'm not really sure how long it gets stuck like this because I get impatient and kill the process.

If I disable FindBar, the regular built-in search works without issue.

I acknowledge this is probably my own fault for trying to use an enhanced search with fancy visuals, but we can also look at this as an opportunity to figure out optimization for extremely long pages.

@Quicksaver
Copy link
Owner

Yeah, it has a little trouble handling huge pages like that. Improving that is already on my to-do list, although I don't know when I'll be able to do it.

BTW it's probably not the page being huge, but having a lot of matches, as in the thousands. Usually the add-on handles well a few matches even in long pages like that.

@FatOrangutan
Copy link

FatOrangutan commented Jun 18, 2016

I would like to add my vote to this. On a page such as this one, which isn't even particularly long, the native FF search for, say, g takes place instantly, while FBT, even with 'Highlight all matches by default', 'Show highlights grid in the scrollbar' and 'Show sights on current hit / all hits' disabled - which should mean it is doing nothing more than the native search - brings the browser to a halt.

What's worse, if I type greasemonkey right away, FBT should directly search for the whole word instead of starting its search with g which is gonna lock up the browser.

@mausalimi
Copy link

well, if i start typing "greasemonkey" fast enough, it works.
if not, yes, the browser is locked for a very long time, eating the whole CPU core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants