Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not all tests pass #183

Open
aucampia opened this issue Jan 9, 2022 · 6 comments
Open

Not all tests pass #183

aucampia opened this issue Jan 9, 2022 · 6 comments

Comments

@aucampia
Copy link
Member

aucampia commented Jan 9, 2022

Currently there are a couple of failing tests, for details see: https://github.com/RDFLib/sparqlwrapper/runs/4747557845?check_suite_focus=true

@eggplants
Copy link
Contributor

I created PR. it makes some tests passed.

aucampia#1

@aucampia
Copy link
Member Author

aucampia commented Jan 9, 2022

Rather make pr against main repo, there is nothing in here that is not already in master and I'm not actively working on this.

@eggplants
Copy link
Contributor

eggplants commented Jan 10, 2022

Note: SPARQL endpoints of virtuoso and 4store server refuse POST request.
(Depends on the server configuration?)

@eggplants
Copy link
Contributor

For cases decorated by expectedFailure, I think we need to change it to skip later.
And in the future, I'd like to generate pytest classes from configuration files (e.g. yaml or ini) for each server.

@aucampia
Copy link
Member Author

For cases decorated by expectedFailure, I think we need to change it to skip later. And in the future, I'd like to generate pytest classes from configuration files (e.g. yaml or ini) for each server.

If we don't expect the test to pass for a specific endpoint then yes, skip makes more sense, but then in that case we should not even really have a test, and if we take the approach of having an endpoint spec in yaml which specifies the feautres of an endpoint then it probably makes most sense to just not generate them, but I can also see how skip would make sense then, so I'm open to both options.

Thank you for all your effort and appologies that we don't direct more efforts towards this repo.,

@eggplants
Copy link
Contributor

OK.

Thank you for your reviewing and supporting too. I think this library is quite useful and should be maintained.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants