Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update buggy JavaScript::Minifier to version 1.16 #771

Closed
ymyasoedov opened this issue Feb 3, 2021 · 4 comments
Closed

Update buggy JavaScript::Minifier to version 1.16 #771

ymyasoedov opened this issue Feb 3, 2021 · 4 comments
Assignees
@bschmalhofer
Labels
enhancement New feature or request
Milestone
OTOBO 10.0.13

Comments

@ymyasoedov
Copy link
Contributor

JavaScript::Minifier 1.14 has some problem that has been found in znuny/Znuny#6 (it is corrupting some JS code). There is also alternative package JavaScript::Minifier::XS, that could be used instead of JavaScript::Minifier. Znuny will use JavaScript::Minifier::XS and CSS::Minifier::XS if they are installed on system.
@svenoe svenoe added the bug Something isn't working as intended label Feb 3, 2021
@svenoe svenoe added this to the OTOBO 10.0.8 milestone Feb 3, 2021
@svenoe
Copy link
Collaborator

svenoe commented Feb 3, 2021

Hi Yuri,

thanks very much for the note. We will definitely incorporate the relevant bugfixes of the Znuny team in general.

Sven

@svenoe
Copy link
Collaborator

svenoe commented Feb 9, 2021

To me it looks like this was related to CKEditor 4.15.1 and does not occur with 4.16.0. We should consider switching to the XS versions anyways, I guess. I will postpone it to 10.0.9 though.

@svenoe svenoe modified the milestones: OTOBO 10.0.8, OTOBO 10.0.9 Feb 9, 2021
@svenoe svenoe added enhancement New feature or request and removed bug Something isn't working as intended labels Feb 9, 2021
@svenoe svenoe modified the milestones: OTOBO 10.0.9, OTOBO 10.0.10 Feb 19, 2021
@svenoe svenoe modified the milestones: OTOBO 10.0.10, OTOBO 10.0.11 Apr 20, 2021
@bschmalhofer bschmalhofer modified the milestones: OTOBO 10.0.11, OTOBO 10.0 Jul 3, 2021
@bschmalhofer bschmalhofer changed the title Update buggy JavaScript::Minifier to version 1.15 Update buggy JavaScript::Minifier to version 1.16 Aug 26, 2021
@bschmalhofer bschmalhofer self-assigned this Aug 26, 2021
@bschmalhofer
Copy link
Contributor

There is now JavaScript::Minfier with more fixes. See zoffixznet/JavaScript-Minifier#12. I think that this can safely be rolled out with OTOBO 10.0.13.

@bschmalhofer bschmalhofer mentioned this issue Aug 26, 2021
Closed
bschmalhofer added a commit that referenced this issue Aug 27, 2021
@bschmalhofer
Issue #771: upgrade JavaScript::Minifier to 1.16.
9745488
bschmalhofer added a commit that referenced this issue Aug 27, 2021
@bschmalhofer
Issue #771: update copying info on JavaScript::Minifier
8d012ac
bschmalhofer added a commit that referenced this issue Aug 27, 2021
@bschmalhofer
Merge pull request #1198 from RotherOSS/issue-#771-js_minifier
cfa367e 
Issue #771 js minifier
@bschmalhofer
Copy link
Contributor

Updated the Perl module. Did a quick test whether the UI still works. Merged the PR.
See #1197 about a possible switch to JavaScript::Minifier::XS. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bschmalhofer bschmalhofer

Labels
enhancement New feature or request
Projects
None yet
Milestone
OTOBO 10.0.13
Development

No branches or pull requests
3 participants
@bschmalhofer @ymyasoedov @svenoe