Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New deprecations #31

Closed
weppos opened this issue Sep 18, 2010 · 8 comments
Closed

New deprecations #31

weppos opened this issue Sep 18, 2010 · 8 comments

Comments

@weppos
Copy link
Member

weppos commented Sep 18, 2010

I would deprecate the following legacy behaviors, with target Money 3.3.

  1. format(option1, option2, ...) in favor of format(:option1 => ..., :option2 => ...)
  2. Money.new(:currency => "EUR")

Any objection?

@semmons99
Copy link
Member

That would be great. I really like to get to a point by 3.5.0 where we don't have those types of hacks around anymore.

@weppos
Copy link
Member Author

weppos commented Sep 19, 2010

Deprecated Money#format with separate params instead of Hash.
Deprecated Money#new(0, :currency => "EUR") in favor of Money#new(0, "EUR").

Deprecation target set to Money 3.5.0. (closed by 31214fe)

@weppos
Copy link
Member Author

weppos commented Sep 19, 2010

In d579d11 I also removed all the deprecations with target v3.2.0. I made it in a branch then merged the branch so we can easily revert the merge if we don't agree with it.

@semmons99
Copy link
Member

Lets back those changes out and leave them in a v3.2.0 branch for now. I'd like to release at least one more 3.1.* version before 3.2.0 to give everyone a little more time to remove their deprecated code.

@weppos
Copy link
Member Author

weppos commented Sep 19, 2010

Just to know, are you going to include the BigDecimal, #dollars and core extension changes in a 3.1.x release?

IMHO, they all deserve a minor bump ;)

By the way, I reverted the commit. I'm going to push the changes tomorrow.

@weppos
Copy link
Member Author

weppos commented Sep 19, 2010

For future reference, here's a tutorial to revert the revert of a merge.
http://www.kernel.org/pub/software/scm/git/docs/howto/revert-a-faulty-merge.txt

Required to re-include the branch in to master when we are ready to merge the changes.

@semmons99
Copy link
Member

I'm thinking a 3.1.5 bump for BigDecimal and #dollars

@weppos
Copy link
Member Author

weppos commented Sep 21, 2010

Pushed the revert commit. Do you want to package a release now or are you waiting for #32?

Losangelosgenetics pushed a commit to Losangelosgenetics/money that referenced this issue Mar 13, 2020
Added ability to use historical data
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants