Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible hide MenuItem by visible property #1088

Closed
cadupper opened this issue Aug 1, 2016 · 6 comments
Closed

Impossible hide MenuItem by visible property #1088

cadupper opened this issue Aug 1, 2016 · 6 comments

Comments

@cadupper
Copy link

cadupper commented Aug 1, 2016

OpenUI5 version: 1.38

Browser/version (+device/version):

Any other tested browsers/devices(OK/FAIL):

URL (minimal example if possible):

http://stackoverflow.com/questions/38695606/set-visible-property-of-menuitem?noredirect=1#comment64770229_38695606

User/password (if required and possible - do not post any confidential information here):

Steps to reproduce the problem:
1.Download zip code from https://openui5.hana.ondemand.com/explored.html#/sample/sap.m.sample.MenuButton/code/MB.view.xml
2. Set propery visible = 'false' in MenuItem
3. Run application

What is the expected result?
Every MenuItem where I set visible = false should not be visible

What happens instead?
I see always all MenuItems

Any other information? (attach screenshot if possible)

@TobiasOetzel
Copy link
Contributor

Hi,

Thanks for reporting the issue. I was able to reproduce the issue in this bin.
The property is taken into account when it has rendered already.
Tracked internally 1680193329

best regards,
Tobias

openui5bot pushed a commit that referenced this issue Aug 15, 2016
Fixes #1088
BCP: 1680193329

Change-Id: Ibb44c51d91c8b559b30d341cefa1979872455b5d
CR-Id: 012006153200001417132016
openui5bot pushed a commit that referenced this issue Aug 17, 2016
Fixes #1088
BCP: 1680193329

Change-Id: Ibb44c51d91c8b559b30d341cefa1979872455b5d
CR-Id: 012006153200001417122016
@cadupper
Copy link
Author

cadupper commented Aug 30, 2016

release1.40.6 fix the bug
But I want use the last long-term maintenance release (1.38.x)... I don't see the fix here

@matz3
Copy link
Member

matz3 commented Sep 1, 2016

6355c1a is part of rel-1.38. It's just not part of a patch release, yet.

@rksgsn
Copy link

rksgsn commented Sep 6, 2016

When can we expect 6355c1a to be made part of a patch release in 1.38?

@cadupper
Copy link
Author

News?

@matz3
Copy link
Member

matz3 commented Sep 26, 2016

@cadupper 1.38.8 is now available and contains the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants