Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

about the parameter kCorrespondences #110

Open
tust13018211 opened this issue Jan 16, 2023 · 4 comments
Open

about the parameter kCorrespondences #110

tust13018211 opened this issue Jan 16, 2023 · 4 comments

Comments

@tust13018211
Copy link

Thanks for your work, I feel a little strange about the parameter kCorrespondences. I test gicp in my data, I find set kCorrespondences=1 in scan to scan is batter than kCorrespondences=10 or kCorrespondences=20. In my opinio, kCorrespondences=1 means the covariance is the same, sames as the icp, so, I don`t konw the reason why ?

@koide3
Copy link
Member

koide3 commented Jan 20, 2023

That sounds strange. As you said, if k_correspondences == 1, covariances would get corrupted and the result might be something similar to that of the conventional ICP. How did you measure the accuracy?

@tust13018211
Copy link
Author

sorry reply later, just take a holiday, First, I use 2 step, scan2sacn and scan2map, scan2map the kCorrespondences=20 keep the same, and scan2sacn I test kCorrespondences=1 and kCorrespondences=10, the result as bleow,
At first , kCorrespondences=1 :

1

and then , set kCorrespondences=10 :
2

as you can see the red line mean the track of car, when set kCorrespondences=10, the track backfold obviously. I just use this phenomenon to see the the accuracy.

In addition, I have a anthoner problem, I want to set some point high weight, how can i do this?

@tust13018211
Copy link
Author

About the another problem, I want to make some special point have high weight, my way like this, when calculate mahalanobis_[i] of every point, I do this for special point:
mahalanobis_[i]=5* mahalanobis_[i];

Is this right?

@koide3
Copy link
Member

koide3 commented Feb 1, 2023

Yes, mahalanobis is the inverse of a covariance, and by weighting it, you should be able to give a large weight for a point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants