New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some fixes to the Build system on OS X #1129
Conversation
Can one of the admins verify this patch? |
test this please |
Stephan, I'm not sure why the build is failing, but it looks like that it is not able to locate the Boost installation. I have to assume that your changes are causing the problems since you touched that part in your pull request. |
I haven't looked into it yet. I tested on OS X with MacPorts boost and on Ubuntu 14.04. What is you motivation on rewriting all the Finders from CMake again, in a different way which makes debugging a pain and break existing setups? I do build other CMake software with similar dependencies regularly, and was frankly quite astonished by the amount of reinventing existing functionality. Edit: To end on a positive note: I've heard great things about your work from @biddisco, and am looking forward to use HPX for some upcoming work! |
Am 10.05.2014 13:13 schrieb "Stefan Eilemann" notifications@github.com:
I agree, there is too much duplication here. Most of the scripts were written |
Blinking Flip Stefan. I read this on the train and almost choked on my sandwich. The other passengers were about to pull the emergency cord and get help for me. Comments like this one coming from someone who’s butchered more cmake projects than Sweeney Todd – whatever next! JB |
Can one of the admins verify this patch? |
What's left to be done here? Can this be merged? |
I need to fix the tests with this change, but haven't had the time to do it. |
The build log got deleted - how do I get it again? |
ok to test. The logs should get regenerated now. |
Can one of the admins verify this patch? |
The MSVC build error can be ignored. Misconfiguration on my side. |
This should be fixed by ecdb034. Please reopen if the problem still persists. |
No description provided.