Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes to the Build system on OS X #1129

Closed
wants to merge 5 commits into from
Closed

Conversation

eile
Copy link

@eile eile commented May 9, 2014

No description provided.

@StellarBot
Copy link

Can one of the admins verify this patch?

@hkaiser hkaiser added this to the 0.9.9 milestone May 9, 2014
@hkaiser
Copy link
Member

hkaiser commented May 9, 2014

test this please

@hkaiser
Copy link
Member

hkaiser commented May 9, 2014

Stephan, I'm not sure why the build is failing, but it looks like that it is not able to locate the Boost installation. I have to assume that your changes are causing the problems since you touched that part in your pull request.

@eile
Copy link
Author

eile commented May 10, 2014

I haven't looked into it yet. I tested on OS X with MacPorts boost and on Ubuntu 14.04.

What is you motivation on rewriting all the Finders from CMake again, in a different way which makes debugging a pain and break existing setups? I do build other CMake software with similar dependencies regularly, and was frankly quite astonished by the amount of reinventing existing functionality.

Edit: To end on a positive note: I've heard great things about your work from @biddisco, and am looking forward to use HPX for some upcoming work!

@sithhell
Copy link
Member

Am 10.05.2014 13:13 schrieb "Stefan Eilemann" notifications@github.com:

I haven't looked into it yet. I tested on OS X with MacPorts boost and on
Ubuntu 14.04.

What is you motivation on rewriting all the Finders from CMake again, in
a different way which makes debugging a pain and break existing setups? I
do build other CMake software with similar dependencies regularly, and was
frankly quite astonished by the amount of reinventing existing
functionality.

I agree, there is too much duplication here. Most of the scripts were written
by Bryce, I'm not sure about his rationale. I for one would welcome the
reduction of complexity in our cmake code by shifting the responsibility
back to cmake mainline.

@biddisco
Copy link
Contributor

What is you motivation on rewriting all the Finders from CMake again, in a different way which makes debugging a pain and break existing setups? I do build other CMake software with similar dependencies regularly, and was frankly quite astonished by the amount of reinventing existing functionality.
<

Blinking Flip Stefan. I read this on the train and almost choked on my sandwich. The other passengers were about to pull the emergency cord and get help for me. Comments like this one coming from someone who’s butchered more cmake projects than Sweeney Todd – whatever next!

JB

@StellarBot
Copy link

Can one of the admins verify this patch?

@hkaiser
Copy link
Member

hkaiser commented Jun 3, 2014

What's left to be done here? Can this be merged?

@eile
Copy link
Author

eile commented Jun 3, 2014

I need to fix the tests with this change, but haven't had the time to do it.

@eile
Copy link
Author

eile commented Jun 5, 2014

The build log got deleted - how do I get it again?

@sithhell
Copy link
Member

ok to test. The logs should get regenerated now.

@StellarBot
Copy link

Can one of the admins verify this patch?

@sithhell
Copy link
Member

The MSVC build error can be ignored. Misconfiguration on my side.

@sithhell
Copy link
Member

sithhell commented Sep 3, 2014

This should be fixed by ecdb034. Please reopen if the problem still persists.

@sithhell sithhell closed this Sep 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants