Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hpx / hpx / config / compiler_specific.hpp #1139

Closed
hadimontakhabi opened this issue May 28, 2014 · 4 comments
Closed

hpx / hpx / config / compiler_specific.hpp #1139

hadimontakhabi opened this issue May 28, 2014 · 4 comments
Assignees
@hkaiser
Labels
category: core compiler: gcc type: defect
Milestone
0.9.9

Comments

@hadimontakhabi
Copy link

I wonder in the following file,
hpx / hpx / config / compiler_specific.hpp
GNUC__PATCHLEVEL should be changed to GNUC_PATCHLEVEL?
@hkaiser
Copy link
Member

hkaiser commented May 28, 2014

What is your rationale? Pure esthetics?

@hadimontakhabi
Copy link
Author

Well, if we are using the predefined macro, as it is defined here:
https://gcc.gnu.org/onlinedocs/gcc-4.9.0/cpp/Common-Predefined-Macros.html
then that is the right macro to use. Otherwise, the macro that we are using now is not defined anywhere!

@hkaiser
Copy link
Member

hkaiser commented May 28, 2014

Ahh, excellent catch! thanks!

@hkaiser
Copy link
Member

hkaiser commented May 28, 2014

Fixed by d8679d3

@hkaiser hkaiser closed this as completed May 28, 2014
@hkaiser hkaiser added this to the 0.9.9 milestone May 28, 2014
@hkaiser hkaiser self-assigned this May 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hkaiser hkaiser

Labels
category: core compiler: gcc type: defect
Projects
None yet
Milestone
0.9.9
Development

No branches or pull requests
2 participants
@hkaiser @hadimontakhabi