Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functions revamp #1152

Merged
merged 4 commits into from Jun 12, 2014
Merged

Functions revamp #1152

merged 4 commits into from Jun 12, 2014

Conversation

K-ballo
Copy link
Member

@K-ballo K-ballo commented Jun 11, 2014

This patch redesigns the vtables used by function and unique_function, making them reusable. It also factors their basic shared implementation into a basic_function. Finally, it adjusts the interface of unique_function to match that of function completely, and moves it out of the detail namespace.

@hkaiser hkaiser added this to the 0.9.9 milestone Jun 11, 2014
@hkaiser
Copy link
Member

hkaiser commented Jun 11, 2014

I'm fine with merging this.

@sithhell
Copy link
Member

Looks pretty good. Do we have buildbot results for that?

@K-ballo
Copy link
Member Author

K-ballo commented Jun 12, 2014

Here: http://hermione.cct.lsu.edu/builders/hpx_gcc44_x8664_boost149_debug/builds/490

hkaiser added a commit that referenced this pull request Jun 12, 2014
@hkaiser
Merge pull request #1152 from STEllAR-GROUP/functions_revamp
4eb5414 
Functions revamp
@hkaiser hkaiser merged commit 4eb5414 into master Jun 12, 2014
@hkaiser hkaiser deleted the functions_revamp branch June 12, 2014 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@K-ballo K-ballo

Labels
category: core type: enhancement
Projects
None yet
Milestone
0.9.9
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@K-ballo @hkaiser @sithhell