Do not put -DNDEBUG into hpx_application.pc

[eschnett]

HPX should not put -DNDEBUG into its hpx_application.pc. The choice of using -DNDEBUG or not should belong to the application, not a library (HPX) that an application uses. It is often very convenient to be able to use assert() to track down bugs, even in production code. -DNDEBUG prevents this, forcing people to roll their own assert statement.

Since HPX already uses HPX_ASSERT, why does it care about -DNDEBUG? This seems like an overzealous optimization to me; HPX_DISABLE_ASSERTS should suffice.

[hkaiser]

NDEBUG can be safely removed there, we don't need it anymore. Thanks for catching this!

[sithhell]

The c stdlib headers actually need it (plain assert for example). But i agree with Erik that it should be removed from the compile flags. I am on it

[sithhell]

This should be fixed by ecdb034. Please reopen if the problem still persists.