Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new AGAS cache performance counters #1219

Merged
merged 4 commits into from Aug 12, 2014
Merged

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Aug 11, 2014

This pull request adds new AGAS cache performance counters for counting the number of invocations and getting the overall time executing various AGAS cache functions. Use them by specifying:

--hpx:print-counter=/agas/count/cache_*
--hpx:print-counter=/agas/time/cache_*

…s and getting the overall time executing various AGAS cache functions.
{ "/agas/count/cache_get_entry", performance_counters::counter_raw,
"returns the number of invocations of get_entry function of the "
"AGAS cache",
HPX_PERFORMANCE_COUNTER_V1,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we use V1 and not V2 here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have only V1, currently. This version stands for the used API of the counters. What is your rationale to use V2 instead?

@parsa
Copy link
Contributor

parsa commented Aug 12, 2014

Counters work as advertised.

hkaiser added a commit that referenced this pull request Aug 12, 2014
Adding new AGAS cache performance counters
@hkaiser hkaiser merged commit 2259244 into master Aug 12, 2014
@hkaiser hkaiser deleted the agas_cache_perf_counters branch August 12, 2014 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants