Avoid CMake name clash for Boost.Thread library #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FindBoost uses Boost_THREAD_LIBRARY to denote the library filename to link when using Boost.Thread. HPX_SetupBoost.cmake used BOOST_THREAD_LIBRARY as the target to detect the underlying platform threading library used by Boost.Thread. As find_library avoids the search if the cache variable exists, this search was always a no-op. The temporary name is now instead BOOST_UNDERLYING_THREAD_LIBRARY.
sithhell
added a commit
that referenced
this pull request
Sep 23, 2014
Avoid CMake name clash for Boost.Thread library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FindBoost uses
Boost_THREAD_LIBRARYto denote the library filename tolink when using Boost.Thread.
HPX_SetupBoost.cmake used
BOOST_THREAD_LIBRARYas the target to detectthe underlying platform threading library used by Boost.Thread. As
find_library avoids the search if the cache variable exists, this search
was always a no-op.
The temporary name is now instead
BOOST_UNDERLYING_THREAD_LIBRARY.