N4071 Search/Search_n finished, minor changes #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ritten for search.cpp
|
Wow! Thanks Grant! I'll have a closer look at this asap. |
|
|
||
| #include <hpx/parallel/algorithms/search.hpp> | ||
|
|
||
| #endif |
There was a problem hiding this comment.
This file does not end in a newline
|
It seems the tests were not catching the error in iterator type checking because it does not test the type of a newline has also been added to the end of parallel_search.hpp |
hkaiser
added a commit
that referenced
this pull request
Nov 22, 2014
N4071 Search/Search_n finished, minor changes
47 tasks
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been a little caught up with school work but I finally finished some long overdue algorithms, search and search_n should be fully functional and have in-depth tests written. A short summary of whats changed:
search,search_nimplementedcall_with_dataadded to partitioner for future use withcopy_ifcopy_iftest temporary disabled from being built(I will continue working on it in branch N4071)find_first_ofdocumentation