Attempting to fix hangs during shutdown. #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| typedef hpx::lcos::local::spinlock mutex_type; | ||
| mutex_type sender_threads_mtx_; | ||
| std::list<threads::thread_id_type> sender_threads_; | ||
|
|
There was a problem hiding this comment.
How many threads do you expect to be active at the same time? Would a std::set be more appropriate to avoid the linear search (see L776)?
There was a problem hiding this comment.
A std::set might indeed be more appropriate. This way we can avoid one linear search. We need one linear search to scan for suspended threads though. The maximum number of active threads is limited by the maximum connections in the cache.
- race condition in mutex caused by spurios wakeups
- avoiding locks being hold during suspension in locality and symbol namespace (this led to hangs at startup)
| BOOST_FOREACH(refcnt_requests_type::const_reference e, *p) | ||
| // Only send decref requests if we aren't in shutdown mode, if we shut down, the corresponding | ||
| // component will get destroyed eventually. | ||
| if(!get_runtime().get_state() != runtime::state_shutdown) |
There was a problem hiding this comment.
I believe, this has to be:
if(get_runtime().get_state() < runtime::state_shutdown)
instead.
There was a problem hiding this comment.
Note, that the '!' is superfluous in any case.
sithhell
added a commit
that referenced
this pull request
Jan 9, 2015
Attempting to fix hangs during shutdown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is attempting to fix distributed hangs that manifested during shutdown.