Variadic when and wait functions #1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| result_type lazy_values_( | ||
| BOOST_PP_ENUM(N, HPX_WAIT_SOME_GET_SHARED_STATE, _)); | ||
| result_type lazy_values_(lcos::detail::get_shared_state(ts)...); |
There was a problem hiding this comment.
Doesn't this cause a pattern-matching ICE?
There was a problem hiding this comment.
Interesting - it should. Apparently this is not tested anywhere.
|
LGTM |
hkaiser
added a commit
that referenced
this pull request
Jan 11, 2015
Variadic when and wait functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch proposes to change the implementation of all
wait_xxxandwhen_xxxfree functions to use variadics. This introduces API breaking changes for some of those, the sequence of the parameter have been changed to ensure that all variadic arguments come last.This patch also adds the missing documentation for
when_eachandwait_each.All tests pass: http://hermione.cct.lsu.edu/builders/hpx_gcc_4_9_boost_1_56_debian_x86_64_debug/builds/217