HPXConfig.cmake should include TCMALLOC_LIBRARY and TCMALLOC_INCLUDE_DIR

[kynan]

If TCMalloc is installed in a non-standard location i.e. TCMALLOC_LIBRARY and TCMALLOC_INCLUDE_DIR are set in the CMake cache, these variables should be written to HPXConfig.cmake. Not doing that causes find_package(HPX REQUIRED) to fail with the familiar

Could NOT find TCMalloc (missing:  TCMALLOC_LIBRARY TCMALLOC_INCLUDE_DIR)

In particular, this causes the build test (tests/unit/build) to fail.

[kynan]

The following patch works for me:

diff --git a/cmake/templates/HPXConfig.cmake.in b/cmake/templates/HPXConfig.cmake.in
index 9ba4dc3..dbc0060 100644
--- a/cmake/templates/HPXConfig.cmake.in
+++ b/cmake/templates/HPXConfig.cmake.in
@@ -36,6 +36,8 @@ set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} @CXX11_FLAG@")

 set(HPX_BOOST_ROOT @BOOST_ROOT@)
 set(HPX_MALLOC @HPX_MALLOC@)
+set(TCMALLOC_LIBRARY @TCMALLOC_LIBRARY@)
+set(TCMALLOC_INCLUDE_DIR @TCMALLOC_INCLUDE_DIR@)

 if(NOT HPX_CMAKE_LOGLEVEL)
   set(HPX_CMAKE_LOGLEVEL "WARN")

[kynan]

Maybe better make it conditional:

diff --git a/cmake/templates/HPXConfig.cmake.in b/cmake/templates/HPXConfig.cmake.in
index 9ba4dc3..434ccc8 100644
--- a/cmake/templates/HPXConfig.cmake.in
+++ b/cmake/templates/HPXConfig.cmake.in
@@ -36,6 +36,10 @@ set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} @CXX11_FLAG@")

 set(HPX_BOOST_ROOT @BOOST_ROOT@)
 set(HPX_MALLOC @HPX_MALLOC@)
+if("${HPX_MALLOC}" STREQUAL "tcmalloc")
+  set(TCMALLOC_LIBRARY @TCMALLOC_LIBRARY@)
+  set(TCMALLOC_INCLUDE_DIR @TCMALLOC_INCLUDE_DIR@)
+endif()

 if(NOT HPX_CMAKE_LOGLEVEL)
   set(HPX_CMAKE_LOGLEVEL "WARN")

[sithhell]

This is not a problem specific to tcmalloc but probably affects all other allocators.

[kynan]

Suppose so. I've only tried tcmalloc...

[sithhell]

Thanks for the report! I think the latest changes should take care of the problem at hand.