Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1419 #1428

Closed
wants to merge 9 commits into from
Closed

Fixes #1419 #1428

wants to merge 9 commits into from

Conversation

nidhimj22
Copy link
Contributor

No description provided.

@@ -198,11 +198,11 @@ namespace hpx
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This array of state names needs adaptation as well (see the function get_runtime_state_name() below).

@nidhimj22
Copy link
Contributor Author

Yes, prepending them with state_ would be better because these states are also the names of some functions (e.g shutdown, stopped). That is why some names have state_ prepended.

@hkaiser
Copy link
Member

hkaiser commented Mar 28, 2015

While this PR nicely merges the two state enum types, it fixes only the use of one of them (runtime::state). The use of the former hpx::state enum values has not been adapted. There are many places where the code today relies on bitmask operations for these values (for instance: https://github.com/STEllAR-GROUP/hpx/blob/master/src/runtime/parcelset/parcelhandler.cpp#L82). All these existing pieces need to be thoroughly analyzed to make sure we don't change existing behavior.

@hkaiser
Copy link
Member

hkaiser commented Apr 16, 2015

@nidhimj22: Are you still planning to work on this?

@nidhimj22
Copy link
Contributor Author

@hkaiser Yes, I a am planning to fix this. I have been a little busy with school exams and pending projects,I will fix it asap.

@hkaiser
Copy link
Member

hkaiser commented May 6, 2015

@nidhimj22 It's been a while, do you still plan to work on this? We've had complaints from users that this needs to be fixed.

@hkaiser
Copy link
Member

hkaiser commented May 15, 2015

This is superseded by #1512

@hkaiser hkaiser closed this May 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants