added missing install rule, removed some dead CMake code #1434
Conversation
| FILES_MATCHING PATTERN "hpxcxx" EXCLUDE) | ||
| FILES "${CMAKE_BINARY_DIR}/bin/hpxrun.py" | ||
| DESTINATION bin | ||
| COMPONENT core) | ||
|
|
There was a problem hiding this comment.
The previous code did not install anything, so I deleted it. The new code installs hpxrun.py which I need for the LGD test.
There was a problem hiding this comment.
Doesn't this remove hpxcxx? This sounds wrong!
There was a problem hiding this comment.
Heller: look again at the original code. The rule I had removed actually excludes hpxcxx. There are two hpxcxx in the build tree. The original code specifically excluded this hpxcxx as it is configured for the build tree.
There was a problem hiding this comment.
If the diff isn't clear: please take a look at the individual commits. Together with the accompanying messages, they should be self-explaining.
There was a problem hiding this comment.
The previous code did not install anything, so I deleted it. The new code installs
hpxrun.py which I need for the LGD test.
Sure, what I meant is why did you remove the FILE_PERMISSIONS clause? Shouldn't scripts be made executable?
|
Gotcha. I've re-added the permissions for hpxrun.py and also copied those over for hpxcxx (which was missing them, too). |
|
Perfect, Thanks a lot! |
added missing install rule, removed some dead CMake code
No description provided.