New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidating new_<>() #1456
Consolidating new_<>() #1456
Conversation
@sithhell: The last commit fixed the things you mentioned. |
else if (localities_.size() == 1) | ||
{ | ||
return stub_base<Component>::create_async( | ||
localities_.front(), std::forward<Ts>(vs)...); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it intended to only use the first locality here? Shouldn't it rather use the "best"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is only one locality it's always the first one, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
D'oh...
This patch introduces a consolidation of
hpx::new_<>()
. The following overloads have been implemented:This patch also introduces 3 distribution policies:
default_distribution_policy
,binpacking_distribution_policy
, andcollocating_distribution_policy
. All overloads ofnew_
above can be invoked with one of the distribution policies instead of the target localityloc
, for instance:All of the above also allowed to remove the
new_colocated
API functions, and thedistributing_factory
andbinpacking_factory
components.For convenience, this patch also renames
HPX_REGISTER_MINIMAL_COMPONENT_FACTORY
toHPX_REGISTER_COMPONENT
.