Removing hpx::util::polymorphic_factory #1470
Conversation
|
Could you rebase this on master, please? |
…ation Conflicts: hpx/runtime/actions/continuation.hpp hpx/runtime/components/plain_component_factory.hpp
|
done. |
|
everything looks very good, thanks. |
| std::vector<naming::id_type> localities = | ||
| hpx::find_remote_localities(type); | ||
| hpx::find_remote_localities(); | ||
|
|
There was a problem hiding this comment.
Is there still a way to identify plain actions for selecting localities supporting them?
There was a problem hiding this comment.
No, since all plain actions have the same component type, this is not possible with those changes. Is this something we really need?
| struct is_nonintrusive_polymorphic<Derived1<T> > | ||
| : boost::mpl::true_ {}; | ||
| }} | ||
|
|
There was a problem hiding this comment.
Shouldn't that use a macro similar to HPX_SERIALIZATION_REGISTER_CLASS() below?
There was a problem hiding this comment.
Yes, unfortunately, the corresponding macro for templated types hasn't been implemented.
There was a problem hiding this comment.
Do you still plan to add such a macro before merging the branch?
Conflicts: hpx/lcos/future.hpp hpx/runtime/actions/continuation.hpp
|
The review comments have been addressed. |
|
LGTM |
Removing hpx::util::polymorphic_factory
This PR primarily removes the need of hpx::util::polymorphic_factory and replaces it with the new facilities provided by hpx.serialization. It also simplifies the plain action registration which does not require to register a fake component type anymore.
This is a breaking change since the plain_action registration macros changed to mirror those of the component_action ones.