New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HPX inspect tool #1486
Merged
Merged
Add HPX inspect tool #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is open for a week now. Please review. This patch proposes a tool which is important for improving our formal code quality. |
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch proposes to add a fork of the Boost inspect tool to HPX. It also enables running this tool on all of the HPX' source code tree during each CircleCI build. This will ensure that a CircleCI build will fail if one or more of the rules are violated which are currently checked by the tool.
The following things have been modified from the Boost version of the inspect tool:
--output=<file>
option)boost-no-inspect
tohpx-no-inspect
This patch also fixes (or suppresses) all reported violations in the HPX source code base.
Here is the output of invoking
inpect --help
: