Made sure detail::condition_variable can be safely destroyed #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s notify_one or notify_all are still executing
| #include <hpx/hpx.hpp> | ||
| #include <hpx/hpx_main.hpp> | ||
| #include <hpx/include/local_lcos.hpp> | ||
| #include <hpx/util/lightweight_test.hpp> |
There was a problem hiding this comment.
Test is called safely_destroy_cv but actually test for promise/future.
There was a problem hiding this comment.
Uhh, right. It still relies on the behavior of the condition_variable, though. Let's change the name of the test, though.
|
LGTM. Should be revisited in a future to see if the design can be improved and made safe. |
hkaiser
added a commit
that referenced
this pull request
May 12, 2015
Made sure detail::condition_variable can be safely destroyed
K-ballo
added a commit
to K-ballo/hpx
that referenced
this pull request
May 16, 2015
Since STEllAR-GROUP#1488, the semantics of locks used with detail::cv where changed in a way that is difficult to handle correctly with Lockables that do not represent ownership. To avoid this fragile scenario, detail::cv now only accepts `boost::unique_lock`s, which are known to be safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made sure
detail::condition_variablecan be safely destroyed while its notify_one or notify_all are still executing. This fixes #1481