Changed return type of bulk executors and added test #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // Create shape argument for parallel_executor | ||
| std::vector<range> split(iter first, iter last, int parts) | ||
| { | ||
| typedef typename std::iterator_traits<iter>::difference_type sz_type; |
|
Could you add some tests for the new |
|
Are the added tests what you had in mind? Only sequential_executor, parallel_executor and parallel_fork_executor was used. Also, next I plan to make tests using the .on syntax for algorithms if there are no objections. |
|
While there is still an #include missing, I'll go ahead and merge it over to the main N4406 branch. That will simplify testing, etc. |
hkaiser
added a commit
that referenced
this pull request
May 22, 2015
Changed return type of bulk executors and added test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default return type of
bulk_executeandbulk_async_executewas changed fromvoidandhpx::future<void>tostd::vector<return_of_F_type>(void if return_of_F_type is void) andstd::vector<hpx::future<return_of_F_type> >for each of the executors and for the behavior of executor_traits. Note that the return type is forwarded from the executor_type so a user can easily create an executor with the behavior described by n4406. This was tested in created_executor.cpp.For sequential_executor, I don't think hpx::util::unwrapped is optimal in bulk_execute. Any suggestions? Also, executor tests compiled on my machine but running thread_pool_executors_test failed about half of the time. I got
{what}: assertion 'running()' failed: HPX(assertion_failure)