Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring async, apply, and dataflow APIs #1570

Merged
merged 6 commits into from Jun 20, 2015
Merged

Refactoring async, apply, and dataflow APIs #1570

merged 6 commits into from Jun 20, 2015

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented May 29, 2015

This is a stop-gap measure to workaround current issues on MSVC

@hkaiser hkaiser added this to the 0.9.11 milestone May 29, 2015
@sithhell
Copy link
Member

The changes look strange to me, but if they help for MSVC I have on objections.

@hkaiser
Copy link
Member Author

hkaiser commented May 31, 2015

The changes look strange to me, but if they help for MSVC I have on objections.

Yes, @K-ballo said the same. The plan is to work on refactoring all of the async overloads to go through some kind of traits system which would allow to avoid the excessive use of SFINAE (same is true for dataflow and future<>::then as well - those are currently implemented using a similar SFINAE mess).

@sithhell
Copy link
Member

Ok, do we have a ticket for that already?

@hkaiser
Copy link
Member Author

hkaiser commented May 31, 2015

Ok, do we have a ticket for that already?

#1576

@hkaiser hkaiser force-pushed the unbreaking_async branch 10 times, most recently from fda894d to 67c09d2 Compare June 9, 2015 10:42
@hkaiser hkaiser changed the title Unbreaking local asyncs Refactoring async, apply, and dataflow APIs Jun 9, 2015
@hkaiser
Copy link
Member Author

hkaiser commented Jun 9, 2015

This PR is now ready for review and merging. It now fixes #1576 as discussed earlier.

@hkaiser
Copy link
Member Author

hkaiser commented Jun 13, 2015

After the last round of modifications the code compiles and runs fine on all platforms including MSVC. Please review now. The patch makes another two platforms in buildbot green.

hkaiser added a commit that referenced this pull request Jun 20, 2015
@hkaiser
Merge pull request #1570 from STEllAR-GROUP/unbreaking_async
2ee250c 
Refactoring async, apply, and dataflow APIs
@hkaiser hkaiser merged commit 2ee250c into master Jun 20, 2015
@hkaiser hkaiser deleted the unbreaking_async branch June 20, 2015 13:04
@hkaiser hkaiser mentioned this pull request Jun 23, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
affecting: LSU category: core compiler: msvc type: enhancement
Projects
None yet
Milestone
0.9.11
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hkaiser @sithhell