Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a check for end line whitespace #1583

Closed
wants to merge 6 commits into from

Conversation

Bcorde5
Copy link
Contributor

@Bcorde5 Bcorde5 commented Jun 2, 2015

The two new files check whether or not files have white space in the end of the line, while the edits to the inspect.cpp file allow the other two files to work.

@hkaiser hkaiser mentioned this pull request Jun 2, 2015
8 tasks
@hkaiser hkaiser added this to the 0.9.11 milestone Jun 2, 2015
@hkaiser
Copy link
Member

hkaiser commented Jun 2, 2015

Have you run inspect on your source code yet? I'm sure it would raise several issues (at least using tabs and missing newline at the end of a file).

@Bcorde5
Copy link
Contributor Author

Bcorde5 commented Jun 2, 2015

Going to run it today, and make changes to all of my local files accordingly.

@hkaiser
Copy link
Member

hkaiser commented Jun 2, 2015

The new checker seems to run fine

LGTM.

Also includes changes to endline_whitespace_check files to shorten them
to character limit.
@Bcorde5
Copy link
Contributor Author

Bcorde5 commented Jun 3, 2015

I did not mean to add these new changes to the pull request, how do I undo this, and create a new pull request?

@zao
Copy link
Contributor

zao commented Jun 3, 2015

The state of the pull request is whatever state the branch you made it currently is at.
I tend to make separate branches for each pull request I make, so that when requirements change and feedback comes in, I can rewrite and force push my branch to make the PR contain exactly what I want.

I don't know if Github allows you to change what branch a PR is based from. If not, it's probably easiest to make a fresh named branch and a new PR with that branch.

See one of mine for how it'd look -- #1044

@Bcorde5
Copy link
Contributor Author

Bcorde5 commented Jun 3, 2015

Thanks for the information, I guess this pull request might have to be as is, but in the future I guess I can make separate branches to create new pull requests.

@hkaiser
Copy link
Member

hkaiser commented Jun 3, 2015

I'd like to ask you to separate those changes into different PRs. We can close this PR and start over by creating separate ones for each of the checkers.

@Bcorde5
Copy link
Contributor Author

Bcorde5 commented Jun 4, 2015

Good idea, I will do it right now

@Bcorde5 Bcorde5 closed this Jun 4, 2015
@Bcorde5
Copy link
Contributor Author

Bcorde5 commented Jun 4, 2015

Tomorrow, I will do separate PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants