New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a check for end line whitespace #1583
Conversation
Have you run inspect on your source code yet? I'm sure it would raise several issues (at least using tabs and missing newline at the end of a file). |
Going to run it today, and make changes to all of my local files accordingly. |
… detected by the checker
The new checker seems to run fine LGTM. |
Also includes changes to endline_whitespace_check files to shorten them to character limit.
I did not mean to add these new changes to the pull request, how do I undo this, and create a new pull request? |
The state of the pull request is whatever state the branch you made it currently is at. I don't know if Github allows you to change what branch a PR is based from. If not, it's probably easiest to make a fresh named branch and a new PR with that branch. See one of mine for how it'd look -- #1044 |
Thanks for the information, I guess this pull request might have to be as is, but in the future I guess I can make separate branches to create new pull requests. |
I'd like to ask you to separate those changes into different PRs. We can close this PR and start over by creating separate ones for each of the checkers. |
Good idea, I will do it right now |
Tomorrow, I will do separate PRs |
The two new files check whether or not files have white space in the end of the line, while the edits to the inspect.cpp file allow the other two files to work.