When using runtime_mode_connect, find the correct localhost public ip… #1654
Conversation
|
This functionality is already available from: https://github.com/STEllAR-GROUP/hpx/blob/master/hpx/util/asio_util.hpp#L26 You might want to consider calling |
|
I believe that I tried that code, but if you resolve the hostname "localhost", it returns "127.0.0.1", which is then used by the remote locality to send stuff back (AFAICT the ip is exchanged with the remote node which tries to send data back to 127.0.0.1 and fails). The patch correctly gets the public ip address of the local node which is then used by the other nodes and works. TBH I'm not 100% certain of what is going wrong, but this patch does get the right ip address and enables me to use srun to launch nodes and connect back without knowing the ip address of the nodes I'm launching on beforehand. |
|
Nod, I can see how that's happening. Could you then factor out your functionality into a separately compiled function (add it to the asio_util pair of files) to avoid having the direct asio code intermixed with the command line handling? |
|
Will do. Also I'll play with the existing code in util just in case I messed up. I can see that in my code I query "" and not "localhost", it might be that if I try that, it will get the ip I want. |
… address
If using --hpx::connect, the worker needs to know the public ip address
of itself so that it can send it to the hpx:agas root where it is used
for communication. If the user does not specify the hpx parcel address
then 127.0.0.1 is assumed, but this only works for localities ilaunched
on the same node.
This patch finds the public ip address and uses that instead.
It may still fail if multiple ip addresses exist for the node,
but it is a better guess than before - providing those ip addresses
support tcp connections then all should be ok.
This is particularly useful when the worker is spawned using
srun app <params> --hpx:hpx=xx.xx.xx.xx:port
where the user does not know which node srun will spawn the worker on
so cannot easily put the correct ip address on the command line.
|
I put the code into hpx::util |
|
LGTM, thanks! |
When using runtime_mode_connect, find the correct localhost public ip…
… address
If using --hpx::connect, the worker needs to know the public ip address
of itself so that it can send it to the hpx:agas root where it is used
for communication. If the user does not specify the hpx parcel address
then 127.0.0.1 is assumed, but this only works for localities ilaunched
on the same node.
This patch finds the public ip address and uses that instead.
It may still fail if multiple ip addresses exist for the node,
but it is a better guess than before - providing those ip addresses
support tcp connections then all should be ok.
This is particularly useful when the worker is spawned using
where the user does not know which node srun will spawn the worker on
so cannot easily put the correct ip address on the command line.