Apex integration #1666
Merged
Apex integration #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // file LICENSE_1_0.txt or copy at http://www.boost.org/LICENSE_1_0.txt) | ||
| //////////////////////////////////////////////////////////////////////////////// | ||
|
|
||
| /ggG/ Naive SMP version implemented with futures. |
There was a problem hiding this comment.
This looks like some leftover from editing.
| } | ||
| catch(hpx::exception const& e) { | ||
| std::cerr << "apex_policy_engine_active_thread_count: caught exception: " | ||
| << e.what() << std::endl; |
There was a problem hiding this comment.
In the case of an exception, I think this function should return and counter_id should be set to an invalid id to avoid further problems.
There was a problem hiding this comment.
This change has been made.
fixes from a couple of months ago. Trying this merge again...
khuck
force-pushed
the
apex_integration
branch
from
58a070c
to
4ec789b
Compare
|
Can we now close this (after #1726 was created)? |
to APEX standalone build to find some of the problems encountered in this integration.
Conflicts: hpx/hpx_fwd.hpp
…ed the second static scheduler constructor, and added a second one for the throttled scheduler.
inspection errors.
Conflicts: hpx/runtime/threads/detail/scheduling_loop.hpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Hartmut! I think everything is merged and tested. Please let me know if there are problems, I will continue to debug.