Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified Scan Partitioner for Algorithms #1696

Merged
merged 2 commits into from Aug 1, 2015
Merged

Modified Scan Partitioner for Algorithms #1696

merged 2 commits into from Aug 1, 2015

Conversation

dcbdan
Copy link
Contributor

@dcbdan dcbdan commented Jul 30, 2015

With these changes, the scan partitioner now takes four functions.
The first two functions are the same as previously, they operate on a
partition and then accumulate the result. The third function now
operates on each partitioner with it's corresponding accumulated result
instead of being called once. The fourth function is just to create a
result type.

Changes accomplish the following:

  • Reduce overhead of calling another partitioner inside of
    scan_partitioner
  • Allow third step to be called as soon as possible instead of waiting
    for all of the accumulated items to be finished
    • allow scan algorithms to not need a temporary data structure
  • allow transform_exclusive_scan to operate in place

With these changes, the scan partitioner now takes four functions.
The first two functions are the same as previously, they operate on a
partition and then accumulate the result. The third function now
operates on each partitioner with it's corresponding accumulated result
instead of being called once. The fourth function is just to create a
result type.

These changes accomplish the following:
 - Reduce overhead of calling another partitioner inside of
   scan_partitioner
 - Allow third step to be called as soon as possible instead of waiting
   for all of the accumulated items to be finished
 - Modify transform_exclusive_scan to operate in place
@hkaiser
Copy link
Member

hkaiser commented Aug 1, 2015

LGTM

hkaiser added a commit that referenced this pull request Aug 1, 2015
 Modified Scan Partitioner for Algorithms
@hkaiser hkaiser merged commit faddd4d into master Aug 1, 2015
@hkaiser hkaiser deleted the scan_partitioner_ branch August 1, 2015 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants