Removing hpx_fwd.hpp includes #1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sithhell
force-pushed
the
header_cleanup
branch
3 times, most recently
from
e7b4ca7
to
f36c291
Compare
|
Can we merge this? It compiles fine under msvc now. |
|
I just checked, this branch fails to compile if |
|
Thanks, I'll try to fix this. |
As a start, this patch removes hpx_fwd.hpp from all of hpx/util and deals with the avalanche for the rest of the headers.
sithhell
force-pushed
the
header_cleanup
branch
from
f36c291
to
f7997f7
Compare
Fixed. |
It seems to be not easily solvable at this point to remove hpx_fwd.hpp from this file right now.
|
LGTM now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a start, this patch removes hpx_fwd.hpp from all of hpx/util and deals with
the avalanche for the rest of the headers