Action invocation count #1774
Merged
Action invocation count #1774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t (local and remote)
hkaiser
force-pushed
the
action_invocation_count
branch
from
794a57f
to
898a479
Compare
|
The atomic increment on each invocation doesn't have a significant impact on performance. |
| #include <hpx/performance_counters/counters.hpp> | ||
|
|
||
| #include <hpx/util/jenkins_hash.hpp> | ||
| #include <hpx/util/safe_lexical_cast.hpp> |
There was a problem hiding this comment.
it seems lexical_cast is not used here
|
@AntonBikineev Thanks for all the comments you made and I wouldn't mind if you fixed all of this. I might not be able to get back to this too soon. |
|
@AntonBikineev Thanks a lot! LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding performance counters for local and remote action invocation counts:
The actual action name has to be specified as the parameter argument, for instance:
In order to get all action invocation counts, wildcard characters can be used (as usual):