Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleaning up util/plugin #1776

Merged
merged 1 commit into from Oct 2, 2015
Merged

Cleaning up util/plugin #1776

merged 1 commit into from Oct 2, 2015

Conversation

sithhell
Copy link
Member

@sithhell sithhell commented Oct 1, 2015

This PR simplifies the plugin code by removing the vertical preprocessor iterations and removes boost.mpl.

@sithhell sithhell added this to the 0.9.11 milestone Oct 1, 2015
@hkaiser
Copy link
Member

hkaiser commented Oct 1, 2015

This is restricting the plugin classes to be allowed to expose one constructor overload only. Should we go for that?

@sithhell
Copy link
Member Author

sithhell commented Oct 1, 2015

On 10/01/2015 12:13 PM, Hartmut Kaiser wrote:

This is restricting the plugin classes to be allowed to expose one constructor overload only. Should we go for that?

We don't need more overloads in our codebase at the moment. I was
striving to simplify the code such that it only has what we currently need.

sithhell added a commit that referenced this pull request Oct 2, 2015
@sithhell
Merge pull request #1776 from STEllAR-GROUP/plugin_cleanup
e3a0e0a 
Cleaning up util/plugin
@sithhell sithhell merged commit e3a0e0a into master Oct 2, 2015
@sithhell sithhell deleted the plugin_cleanup branch October 2, 2015 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
category: core type: enhancement
Projects
None yet
Milestone
0.9.11
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sithhell @hkaiser