Completely removing stackless threads #1777
Conversation
|
Isn't thread_data_base supposed to be extendable? |
|
I think the main motivation was to have stackless threads. I wouldn't think we still need the base class. Right now we don't have a usecase for this, it's an internal class anyway, so we can switch back whenever the need to have it customizable again arises, IMHO. |
| public: | ||
| typedef thread_function_type function_type; | ||
|
|
||
| struct tag {}; | ||
| typedef util::spinlock_pool<tag> mutex_type; | ||
|
|
||
| struct pool_base | ||
| struct pool_type |
There was a problem hiding this comment.
This wrapper over lockfree::pool_type is not needed now.
sithhell
force-pushed
the
remove_stackless_threads
branch
from
ab2d7ee
to
f091640
Compare
|
Please add a note to the whats_new.qbk explaining that we removed this and why. |
This patch removes all notions of stackless threads. In addition thread_data_base has been removed because there was no need for it anymore.
sithhell
force-pushed
the
remove_stackless_threads
branch
from
f091640
to
2217e27
Compare
| @@ -715,8 +715,7 @@ namespace hpx { namespace actions | |||
| #define HPX_ACTION_USES_HUGE_STACK(action) \ | |||
| HPX_ACTION_USES_STACK(action, threads::thread_stacksize_huge) \ | |||
| /**/ | |||
| #define HPX_ACTION_DOES_NOT_SUSPEND(action) \ | |||
| HPX_ACTION_USES_STACK(action, threads::thread_stacksize_nostack) \ | |||
| #define HPX_ACTION_DOES_NOT_SUSPEND(action) | |||
There was a problem hiding this comment.
Should we turn this into a warning saying that the feature has been removed and the macro will be removed eventually as well?
There was a problem hiding this comment.
On 10/01/2015 12:20 PM, Hartmut Kaiser wrote:
@@ -715,8 +715,7 @@ namespace hpx { namespace actions
#define HPX_ACTION_USES_HUGE_STACK(action)
HPX_ACTION_USES_STACK(action, threads::thread_stacksize_huge)
/**/
-#define HPX_ACTION_DOES_NOT_SUSPEND(action) \
- HPX_ACTION_USES_STACK(action, threads::thread_stacksize_nostack)
+#define HPX_ACTION_DOES_NOT_SUSPEND(action)Should we turn this into a warning saying that the feature has been removed and the macro will be removed eventually as well?
It might be save to remove this completely. We didn't announce that
feature and it is not documented.
|
Thanks! LGTM now! |
Completely removing stackless threads
This patch removes all notions of stackless threads. In addition thread_data_base
has been removed because there was no need for it anymore.
In addition, this fixes the currently failing unhandled_exception_582 test.