Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing #1723 #1808

Merged
merged 3 commits into from Oct 23, 2015
Merged

Fixing #1723 #1808

merged 3 commits into from Oct 23, 2015

Conversation

sithhell
Copy link
Member

This PR ticks of the remaining points of #1723.

C++ Standard Libraries provided by gcc 4.6 and upwards. If the 'g++' in your
path is something below that requirement, please add this to your CMAKE_CXX_FLAGS
with the `-gxx-name=/path/to/g++` flag.]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean by 'add 'this' ? The correct version of g++? the library?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On 10/21/2015 01:20 PM, Hartmut Kaiser wrote:

In docs/manual/build_system/prerequisites.qbk
#1808 (comment):

@@ -73,6 +73,11 @@ favorite compiler with hpx visit stellar_hpx_buildbot.
for compiling hpx if you use gcc V4.6.x. Please use either
an earlier or a later version of Boost with this compiler.]

+[important When compiling with the Intel Compiler on Linux systems, we only support

  •  C++ Standard Libraries provided by gcc 4.6 and upwards. If the 'g++' in your
    
  •  path is something below that requirement, please add this to your CMAKE_CXX_FLAGS
    
  •  with the `-gxx-name=/path/to/g++` flag.]
    

What do you mean by 'add 'this' ? The correct version of g++? the library?

'this' was meant to refer to the CMAKE_CXX_FLAGS, do you have a better
formulation for this?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, then the question is more that you should clarify what -gxx-name=/path/to/g++ should point to? I assume a g++ of version >= 4.6. That's not really clear, at least it was not to me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this?

  Important: when compiling with the Intel Compiler on Linux systems, we only support
  C++ Standard Libraries provided by gcc 4.6 and upwards. If the 'g++' in your
  path is older than 4.6, please specify the path of a newer g++ by setting
  CMAKE_CXX_FLAGS='-gxx-name=/path/to/g++' via cmake.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

sithhell added a commit that referenced this pull request Oct 23, 2015
@sithhell sithhell merged commit 6c21cef into master Oct 23, 2015
@sithhell sithhell deleted the fixing_1723 branch October 23, 2015 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants