Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding fedora docs #1839

Merged
merged 4 commits into from May 1, 2016
Merged

Adding fedora docs #1839

merged 4 commits into from May 1, 2016

Conversation

aserio
Copy link
Contributor

@aserio aserio commented Nov 2, 2015

No description provided.


* Install all packages for minimal installation
``
sudo dnf gcc-c++ install cmake boost-build boost boost-devel hwloc-devel \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aserio shouldnt this be sudo dnf install gcc-c++ cmake boost-build ...... instead of sudo dnf gcc-c++ install ..... ? on line 18

@hkaiser hkaiser modified the milestones: 0.9.11, 0.9.12 Nov 12, 2015
@hkaiser hkaiser merged commit d40d973 into master May 1, 2016
@hkaiser hkaiser deleted the adding_fedora_docs branch May 1, 2016 11:56
@sithhell
Copy link
Member

sithhell commented May 1, 2016 via email

@hkaiser
Copy link
Member

hkaiser commented May 1, 2016

I would like to revert that again. I am opposed to that patch, I don't want to have documentation for a specific Linux distribution.

This PR was open for over half a year. That should have been sufficient time to comment...

Especially since this patch doesn't include all options and partially misses information.

Could we add the missing information instead? I don't think that system specifics are a bad thing to have in the docs.

@sithhell
Copy link
Member

sithhell commented May 1, 2016

I actually did comment on this PR, outside of github but comments have been
made.

Could we add the missing information instead? I don't think that system specifics are a bad thing to have in the docs.

Well, we do have a generic way to install HPX on any Linux system. Anything
else should go on the wiki. We can't even maintain those docs appropriately
because we neither test it nor have a fedora system to develop on.

@aserio
Copy link
Contributor Author

aserio commented May 1, 2016

@diehlpk Do you have an opinion on this. These are your changes

@hkaiser
Copy link
Member

hkaiser commented May 1, 2016

@sithhell If you commented on this, then I was not aware of it (or I just don't remember), sorry. My goal was to get PRs integrated (somebody has to do that, right?), there was no negative comment on the PR, the PR looked reasonable after addressing the one comment, so I went ahead.

However, please feel free to create a PR to revert the changes, we can discuss things over there.

@sithhell
Copy link
Member

sithhell commented May 1, 2016

In addition, out changed the version to rc1

@sithhell
Copy link
Member

sithhell commented May 1, 2016

I actually had a quote long discussion with aserio, where we decided to have it open until someone creates the wiki entry for it... Next time, I'll create a ticket or make the comment to the PR directly.

@hkaiser
Copy link
Member

hkaiser commented May 1, 2016

The version is unchanged:

#define HPX_VERSION_TAG "-trunk"
. I have no idea why the diff is showing this.

@diehlpk
Copy link
Member

diehlpk commented May 2, 2016

I strongly recommend to have a installation even for a specific distribution at the documentation or the wiki. My blog post was helpful for my gsc student to set up HPX. My students used it and some people who asked in the irc channel.

@sithhell
Copy link
Member

sithhell commented May 2, 2016

Am 02.05.2016 8:48 vorm. schrieb "Patrick Diehl" notifications@github.com:

I strongly recommend to have a installation even for a specific
distribution at the documentation or the wiki. My blog post was helpful for
my gsc student to set up HPX. My students used it and some people who asked
in the irc channel.

Sure, it's helpful to have such a receipt. Will you maintain, test and
support it?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

@diehlpk
Copy link
Member

diehlpk commented May 2, 2016

Yes, I could do it for Fedora. I usually update my system shortly after the release of the latest Fedora and have to compile it again. Thus, I could update the wiki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants