Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding example demonstrating a possible safe-object implementation #1840

Merged
merged 2 commits into from Nov 5, 2015

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Nov 3, 2015

No description provided.

@hkaiser
Copy link
Member Author

hkaiser commented Nov 3, 2015

@zkhatami88 This should be useful to you.

hkaiser added a commit that referenced this pull request Nov 5, 2015
Adding example demonstrating a possible safe-object implementation
@hkaiser hkaiser merged commit d7a921b into master Nov 5, 2015
@hkaiser hkaiser deleted the safe_object_example branch November 5, 2015 00:39
@sithhell
Copy link
Member

sithhell commented Nov 5, 2015

Why did you merge out twice? Shouldn't it be enough to merge it once?

@hkaiser
Copy link
Member Author

hkaiser commented Nov 5, 2015

The PR against master did exist already. I thought I'd merge it instead of closing it. Later on we would have pushed the very same commit to master (via merging from release) anyways.

@sithhell
Copy link
Member

sithhell commented Nov 5, 2015

The PR against master did exist already. I thought I'd merge it instead of closing it. Later on we would have pushed the very same commit to master (via merging from release) anyways.

Yes sure, saves just one merge commit :p
I guess I would have closed it as duplicate...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants