Fixing problems as reported by clang-check. #1889
Conversation
sithhell
commented
Dec 1, 2015
sithhell
commented
- Fixing memory leaks
- Removing unused variables
- Fixing potential division by zero bugs
| @@ -125,7 +125,8 @@ struct HPX_EXPORT big_boot_barrier : boost::noncopyable | |||
|
|
|||
| void add_thunk(util::unique_function_nonser<void()>* f) | |||
| { | |||
| thunks.push(f); | |||
| while(!thunks.push(f)) | |||
| ; // Wait until succesfully pushed ... | |||
There was a problem hiding this comment.
This should time out with an error and not sit indefinitely.
There was a problem hiding this comment.
In hpx/runtime/agas/big_boot_barrier.hpp:
@@ -125,7 +125,8 @@ struct HPX_EXPORT big_boot_barrier : boost::noncopyable
void add_thunk(util::unique_function_nonser<void()>* f) {
thunks.push(f);while(!thunks.push(f)); // Wait until succesfully pushed ...This should time out with an error and not sit indefinitely.
push is guaranteed to succeed eventually, iiuc. Should we really time out
and throw here?
There was a problem hiding this comment.
push is guaranteed to succeed eventually, iiuc. Should we really time out and throw here?
Not sure. I usually try to avoid things like that. Smells like a live-lock...
There was a problem hiding this comment.
Yes, I think having an additional exponential back off mechanism might help to improve the picture.
|
@sithhell Can this be merged now? |
|
All comments have been addressed. |
…mory leak warning
sithhell
force-pushed
the
clang_analyzer_fixes
branch
from
222d26c
to
ac9c127
Compare
|
LGTM, thanks! |
Fixing problems as reported by clang-check.
