Keep cmake_module_path #1910
Merged
Keep cmake_module_path #1910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If CMAKE_MODULE_PATH was specified previously, keep the values.
We are improving conan.io (c++ package manager) supporting custom FindXXX.cmake for some packages like Boost and Hwloc. So those packages in conan provides their own FindXXX.
If you override the CMAKE_MODULE_PATH, conan won't be able to find the custom finders and the dependencies will be unresolved.
I think it doesn't affect at all to your build system but would be great for HPX conan package.
We are currently improving HPX Package (current version is a very alpha version) generator for conan.io. We hope to have a better version of HPX when we release conan 0.5