New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add utility member functions for partitioned_vector #1913
Conversation
{ | ||
std::vector< hpx::id_type > ids; | ||
|
||
for(auto const part_data : partitions_) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be: for(auto const& part_data : partitions_)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in commit 239ed21
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Just out of curiosity: why do you need this functionality?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It allows my array_view to get all it needs to return the data of a partition. Saving the ids is costless as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, the idea was for the array_view
to access the local data only. Why do you need to get a copy of the local data for this? Wouldn't it be no view anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, misunderstanding - what I wanted to ask is why you need the get_copied_data()
functionality above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for another functionality extending the concept of array_view. If an owner of a array_view needs a data that is not in its locality, make a copy and return it by value.
Well, let's talk about this in more detail. I'm not convinced yet. Wrt
So, you can use the exposed iterators directly without even accessing the partition table inside the |
Add utility member functions for partitioned_vector
This pull request does 2 small changes:
owned by the server