Address sanitizer fixes #1918
Merged
Address sanitizer fixes #1918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clang sanitizers instrument code with symbols that are only loaded at runtime. Linking will fail without disabling this option.
By including lightweight_test.cpp in libhpx.so we introduce an ODR violation
sithhell
force-pushed
the
address_sanitizer_fixes
branch
from
3664581
to
3d7c9c8
Compare
|
LGTM, thanks! |
sithhell
force-pushed
the
address_sanitizer_fixes
branch
from
3d7c9c8
to
54e20b8
Compare
sithhell
force-pushed
the
address_sanitizer_fixes
branch
from
54e20b8
to
cb559f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some memory leaks and a ODR violation reported by clang's address sanitizer