Touching up make_future #1940
Merged
Touching up make_future #1940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add overloads for shared_future - make sure make_continuation(future<T>(future<T>) does not create ambiguities - import make_future into namespace hpx - adding test - flyby change: import make_future_void into namespace hpx
| // conversion function: T f(U). | ||
| template <typename R, typename U, typename Conv, | ||
| HPX_CONCEPT_REQUIRES_( | ||
| hpx::traits::is_callable<Conv(U)>::value)> |
There was a problem hiding this comment.
Should we check if the result of Conv(U) is convertible to R?
There was a problem hiding this comment.
We can do that, I was afraid of over-constraining requirements.
|
@sithhell Your comments have been addressed. |
| }; | ||
|
|
||
| template <> | ||
| struct make_future_helper<void, void> |
There was a problem hiding this comment.
Isn't the template specialization on line 951 enough?
There was a problem hiding this comment.
No, <void, void> is ambiguous between <void, T> and <T, T>
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make_future<T>(future<T>)does not create ambiguities