Add action to update data owned by the partitioned_vector component #1974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// | ||
| /// \return This returns the data of the partition_vector | ||
| /// | ||
| auto set_data_sync(typename server_type::data_type && other) const |
There was a problem hiding this comment.
Do all our compilers support auto return type deduction?
| { | ||
| partition_vector_ = other; | ||
| } | ||
|
|
There was a problem hiding this comment.
I'd suggest to change this to:
void set_data(data_type && data)
{
partition_vector_ = std::move(data);
}
to avoid extra copies of the whole partition.
| void set_data(data_type && other) | ||
| { | ||
| partition_vector_ = other; | ||
| } |
There was a problem hiding this comment.
This will still copy the data (needlessly)
|
LGTM, thanks! |
hkaiser
added a commit
that referenced
this pull request
Feb 2, 2016
Add action to update data owned by the partitioned_vector component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The action is needed to perform a classic "put" operation from remote locality.