Fixing 2000 #2004
Merged
Fixing 2000 #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since assertion_failed/assertion_failed_msg never returns and the compiler can not infer this fact anymore it might be a good idea to mark the function with HPX_ATTRIBUTE_NORETURN. Any objections? |
No objections. |
|
@hkaiser Could you please merge this PR? |
|
@chinz07 I was assuming you'd add the HPX_ATTRIBUTE_NORETURN first, were you planning to do that? |
|
Ok, I'll merge it once buildbot has cycled later today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2000