Refactor local::condition_variable #2072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… definitions to source file
| // splice is constant time only if it == end | ||
| queue.splice(queue.end(), queue_); | ||
| queue_.swap(queue); | ||
| relock_guard rl(lock); |
There was a problem hiding this comment.
Since the lock is moved into wait down below, is it really save to relock it again afterwards?
There was a problem hiding this comment.
Yes, the lock is not actually moved from, only casted to an rvalue.
|
The changes to |
|
LGTM! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
condition_variableandcondition_variable_anydetail::condition_variableto spinlocks only, avoid unnecessary relocking