Making executor_traits N-nary #2127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| policy_.template apply<action_type>( | ||
| threads::thread_priority_default, std::forward<F>(f)); | ||
| policy_.template apply<action_type>(threads::thread_priority_default, | ||
| std::forward<F>(f), std::forward<Ts>(ts)...); |
There was a problem hiding this comment.
Do we really execute something that's not an action with a distribution policy?
There was a problem hiding this comment.
Well, nothing has changed relatively to the implementation of distribution_policies. I'd be happy to discuss this on a separate PR.
There was a problem hiding this comment.
Yeah, it just occurred to me when reading through the code
- making task_block::run N-Nary as well - renamed bulk operations to bulk_async_execute and bulk_execute - flyby: making sequencers const - flyby: switched is_launch_policy and friends to type_traits
- extending tests - flyby: changing result type calculation to use deferred_result_of - flyby: adding missing #includes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2104
The breaking change is that the bulk-
async_executewas renamed tobulk_async_executeand the bulk-executewas renamed tobulk_execute