Changing default bind mode to balanced #2180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -679,7 +679,7 @@ namespace hpx { namespace util | |||
| affinity_domain_ = detail::handle_affinity(cfgmap, vm, "pu"); | |||
| ini_config += "hpx.affinity=" + affinity_domain_; | |||
|
|
|||
| affinity_bind_ = detail::handle_affinity_bind(cfgmap, vm, ""); | |||
| affinity_bind_ = detail::handle_affinity_bind(cfgmap, vm, "balanced"); | |||
| if (!affinity_bind_.empty()) | |||
There was a problem hiding this comment.
Does the empty check still have a purpose since you've set a balanced default?
There was a problem hiding this comment.
On 05/25/2016 11:41 AM, John Biddiscombe wrote:
In src/util/command_line_handling.cpp
#2180 (comment):@@ -679,7 +679,7 @@ namespace hpx { namespace util
affinity_domain_ = detail::handle_affinity(cfgmap, vm, "pu");
ini_config += "hpx.affinity=" + affinity_domain_;
affinity_bind_ = detail::handle_affinity_bind(cfgmap, vm, "");affinity_bind_ = detail::handle_affinity_bind(cfgmap, vm, "balanced"); if (!affinity_bind_.empty())Does the empty check still have a purpose since you've set a balanced
default?
Good catch!
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
https://github.com/STEllAR-GROUP/hpx/pull/2180/files/ddd1295164834781cdedaf198b85db7b098a7a95#r64543813
This fixes #2015
hkaiser
added a commit
that referenced
this pull request
May 26, 2016
biddisco
pushed a commit
to biddisco/hpx
that referenced
this pull request
Jul 2, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2015