Adding callback taking index and future to when_each #2189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This trait checks if a type is callable with a given set of parameter types.
Added a second callback to when_each (and derivates) that takes the index of the future being consumed and the future itself as parameters.
ltroska
changed the title
| template<typename F, typename... Args> | ||
| using is_callable_with = | ||
| decltype(detail::is_callable_with_impl::f<F, Args...>(0)); | ||
|
|
There was a problem hiding this comment.
Please don't use 'using' directives in HPX (yet). Some compilers we use don't fully support this feature.
|
Could you add a test verifying your code works as expected, please? |
If two futures of the same type are passed into when_each individually the compiler picks the iterator version which fails to compile since a future is not an iterator.
|
LGTM, thanks! |
|
@troska: In the test it might be appropriate to verify that the callbacks are actually called. |
|
I think I got everything now :) |
|
@ltroska Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a second callback that also takes in the index of the future currently being consumed.