Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for HPXCL's opencl::event #2227

Merged
merged 2 commits into from Jun 25, 2016
Merged

Support for HPXCL's opencl::event #2227

merged 2 commits into from Jun 25, 2016

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Jun 23, 2016

  • flyby: simplify implementation of lcos::promise

- flyby: simplify implementation of lcos::promise
@hkaiser hkaiser added this to the 0.9.99 milestone Jun 23, 2016
hkaiser added a commit to STEllAR-GROUP/hpxcl that referenced this pull request Jun 23, 2016
{
base_type::set_exception(e, ec);
}
using base_type::set_exception;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does this look like for generated doxygen?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we generate docs using doxygen for this? I didn't think so.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Donnerstag, 23. Juni 2016 13:30:15 CEST Hartmut Kaiser wrote:

@@ -139,20 +133,19 @@ namespace lcos {

     //   - promise_already_satisfied if its shared state already has
     a
     //     stored value or exception.
     //   - no_state if *this has no shared state.
  •    void set_exception(
    
  •        boost::exception_ptr const& e, error_code& ec = throws)
    
  •    {
    
  •        base_type::set_exception(e, ec);
    
  •    }
    
  •    using base_type::set_exception;
    

Do we generate docs using doxygen for this? I didn't think so.

Just checked, we don't, but we probably should, and those are already almost
doxygen comments.


You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/STEllAR-GROUP/hpx/pull/2227/files/64f79a91506d10b1b247f82
a5a9305bb72113870#r68308989

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should probably revert those changes. We have not done it this way (using base_type::...) in other places either.

Also, if we decided to stick with it, we could easily use doxygens \copydoc directive to pull in the docs from the base class, if needed.

@hkaiser hkaiser merged commit a8c21ab into master Jun 25, 2016
@hkaiser hkaiser deleted the opencl_event_support branch June 25, 2016 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants