Drop support for GCC 4.6 and 4.7 #2253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -262,8 +262,7 @@ endif() | |||
| ################################################################################ | |||
| set(HPX_HIDDEN_VISIBILITY_DEFAULT ON) | |||
| if(CMAKE_COMPILER_IS_GNUCXX) | |||
| if(CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 4.6.99 | |||
| AND CMAKE_CXX_COMPILER_VERSION VERSION_LESS 4.8) | |||
| if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 4.8) | |||
| set(HPX_HIDDEN_VISIBILITY_DEFAULT OFF) | |||
| endif() | |||
There was a problem hiding this comment.
Doesn't this patch remove support for anything less than gcc 4.8? I think we don't need this set(HPX_HIDDEN_VISIBILITY_DEFAULT OFF) anymore at all.
There was a problem hiding this comment.
Indeed, that condition will never be true.
|
Very nice, thanks! LGTM |
K-ballo
force-pushed
the
gcc-bump
branch
3 times, most recently
from
4b847c3
to
5b8dd46
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.