Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove most of Boost.MPL, Boost.EnableIf and Boost.TypeTraits #2259

Merged
merged 5 commits into from Jul 26, 2016
Merged

Remove most of Boost.MPL, Boost.EnableIf and Boost.TypeTraits #2259

merged 5 commits into from Jul 26, 2016

Conversation

sithhell
Copy link
Member

No description provided.

@sithhell sithhell added this to the 1.0.0 milestone Jul 21, 2016
@K-ballo
Copy link
Member

K-ballo commented Jul 21, 2016

LGTM

@hkaiser
Copy link
Member

hkaiser commented Jul 21, 2016

We should consider to guard the use of alignof() with a feature test.

@hkaiser
Copy link
Member

hkaiser commented Jul 21, 2016 •
edited

Other things to consider (could be separate PRs):

Thomas Heller added 4 commits July 25, 2016 09:22
Removing Boost.MPL, Boost.EnableIf and Boost.TypeTraits dependency
06a417b 
 - Replaced boost::mpl::and_/or_ with regular boolean expressions
 - Replaced boost::mpl::(eval_)if_ with std::conditional
 - Replaced boost::enable_if (and friends) with std::enable_if
 - Replaced remaining uses of boost type traits with standard ones
Added inspect checks for enable_if, type_traits and mpl
2f833b3
Adding include checks for type_traits
dd50eda
Added missing type_traits header
249886a
@hkaiser
Copy link
Member

hkaiser commented Jul 26, 2016

@sithhell Do you plan to add the alignof() feature test? Any idea whether alignof() can be made mandatory?

@K-ballo
Copy link
Member

K-ballo commented Jul 26, 2016

alignof() will not work on VS2013, but std::alignment_of will.

@sithhell
Copy link
Member Author

sithhell commented Jul 26, 2016 •
edited by hkaiser

alignof has been replaced with the std:: alignment_of

@hkaiser
Copy link
Member

hkaiser commented Jul 26, 2016

LGTM, thanks! Could you create a ticket for the open suggestion above, please (adding deprecated Boost type traits to inspect)?

@sithhell
Copy link
Member Author

See #2267.

@hkaiser hkaiser merged commit a89c2b9 into master Jul 26, 2016
@hkaiser hkaiser deleted the remove_mpl branch July 26, 2016 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sithhell @K-ballo @hkaiser