Child vs parent stealing #2279
Merged
Child vs parent stealing #2279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkaiser
force-pushed
the
child_vs_parent_stealing
branch
3 times, most recently
from
ef67538
to
9752078
Compare
hkaiser
force-pushed
the
child_vs_parent_stealing
branch
from
9752078
to
e558a33
Compare
|
This is working well for me. I looked through the diff and was surprised by HPX_LIKELY() and HPX_UNLIKELY() - what do these macros do (I see the defs cast them to bool, but why this macro?) |
Those are micro optimizations for gcc/clang telling the compiler which branch to favor while generating code. I added those as it is absolutely critical to have the scheduling loop as optimal as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
yield_tofunctionality improving the performance of our parent stealing scheme. This fixes #2248.